Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some links in the threat hunting dashboard table do not redirect or have no links #6845

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Some links in the threat hunting dashboard table do not redirect or have no links #6845

merged 6 commits into from
Jul 22, 2024

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Jul 18, 2024 •
edited
Loading

Description

This PR fix the issue some links in the threat hunting dashboard table do not redirect or have no links

Issues Resolved

#6830

Evidence

Grabacion.de.pantalla.2024-07-18.a.la.s.12.39.17.p.m.mov

Test

  • Go to the Threat Hunting tab, in the dashboard table click on one of the values in the rule.mitre.id field and check that it redirects correctly.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Jul 18, 2024
@chantal-kelm chantal-kelm linked an issue Jul 18, 2024 that may be closed by this pull request
Some links in the Threat Hunting dashboard table do not redirect or have no links #6830
Closed
jbiset
jbiset previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI: 🟢

Evidence

Evidence.webm

@chantal-kelm
Merge branch '4.9.0' into bug/6830-some-links-in-the-threat-hunting-d…
1c2c27b 
…ashboard-table-do-not-redirect-or-have-no-links
yenienserrano
yenienserrano previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

jbiset
jbiset previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR new changes: 🟢

Test UI changes: 🟢

Evidence

image

image

@chantal-kelm chantal-kelm dismissed stale reviews from jbiset and yenienserrano via 403d1e5 July 22, 2024 13:23
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29231 )
Branches 9.1% ( 1744 / 19153 )
Functions 13.35% ( 943 / 7063 )
Lines 13.83% ( 3886 / 28093 )

@Tostti Tostti merged commit 034885e into 4.9.0 Jul 22, 2024
5 checks passed
@Tostti Tostti deleted the bug/6830-some-links-in-the-threat-hunting-dashboard-table-do-not-redirect-or-have-no-links branch July 22, 2024 13:46
@Desvelao
Copy link
Member

This pull request added the field rule.mitre_techniques to the threat hunting table and it should be done.

We will create a pull request to remove this field.

@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@jbiset jbiset jbiset approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some links in the Threat Hunting dashboard table do not redirect or have no links
5 participants
@chantal-kelm @Desvelao @jbiset @yenienserrano @Tostti